Add dynamic title rendered only once, improve PR #25

Rafal Wilinski
Showing 2 changed files with 12 additions and 8 deletions
index.html
index.js
--- a/index.html
View file @24a8bd3
+++ b/index.html
View file @24a8bd3
 <!DOCTYPE html>
 <html>
 <head>
-  <title>Express Status</title>
+  <title>{{title}}</title>
  <script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.2.1/Chart.bundle.min.js"></script>
  <script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/1.4.5/socket.io.min.js"></script>
  <style>
@@ -75,7 +75,7 @@
 <body>
 <div style="width: 600px; margin: auto">
  <div class="header">
-    <b>Express Status</b>
+    <b>{{title}}</b>
    <div id="span-controls" class="span-controls">
    </div>
  </div>
--- a/index.js
View file @24a8bd3
+++ b/index.js
View file @24a8bd3
@@ -73,6 +73,15 @@
      config.spans = defaultConfig.spans;
    }
+    if (config.title === undefined || !config instanceof String) {
+      config.title = 'Express Status';
+    }
+    let renderedHtml;
+    fs.readFile(path.join(__dirname, '/index.html'), function(err, html){
+      renderedHtml = html.toString().replace(/{{title}}/g, config.title);
+    });
    return (req, res, next) => {
      if (io === null || io === undefined) {
@@ -92,12 +101,7 @@
      const startTime = process.hrtime();
      if (req.path === config.path) {
-        fs.readFile(path.join(__dirname + '/index.html'), function(err, content) {
+        res.send(renderedHtml);
-          content = content.toString().replace(new RegExp(defaultConfig.title, 'g'), config.title);
-          res.writeHead(200, {'Content-Type': 'text/html'});
-          res.write(content);
-          res.end();
-        });
      } else {
        onHeaders(res, () => {
          const diff = process.hrtime(startTime);